-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33838/
-----------------------------------------------------------

(Updated May 7, 2015, 4:42 p.m.)


Review request for lens.


Changes
-------

Implementing new review comments. Adding xs:restriction.


Repository: lens


Description
-------

NPE when weight is not set in XFactTable object while creating fact table


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 10b1dfa 
  
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java
 PRE-CREATION 
  lens-cli/src/test/resources/fact_without_weight.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/33838/diff/


Testing
-------

Yes.
TestCase:
        mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands


Thanks,

Yash Sharma

Reply via email to