----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33838/#review84689 -----------------------------------------------------------
lens-client/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/33838/#comment136039> Why are we copying the file into lens-client? We should be using the one from lens-api only. - Amareshwari Sriramadasu On May 21, 2015, 9:39 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33838/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 9:39 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > NPE when weight is not set in XFactTable object while creating fact table > > > Diffs > ----- > > lens-api/pom.xml adc464a > lens-api/src/main/resources/cube-0.1.xsd 06f85ee > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 195bd43 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > PRE-CREATION > lens-cli/src/test/resources/dim-local-storage-element.xml 5a19cfa > lens-cli/src/test/resources/dim_table.xml 932c975 > lens-cli/src/test/resources/dim_table2.xml 1d6e138 > lens-cli/src/test/resources/fact-local-storage-element.xml 8ec3b42 > lens-cli/src/test/resources/fact_without_weight.xml PRE-CREATION > lens-cli/src/test/resources/sample-cube-without-wt.xml PRE-CREATION > lens-cli/src/test/resources/sample-cube.xml d54bcfb > lens-cli/src/test/resources/test-dimension.xml d602569 > lens-client/pom.xml e27a6ce > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 5e406b5 > lens-client/src/main/resources/cube-0.1.xsd PRE-CREATION > lens-examples/src/main/resources/dim_table2.xml eef1513 > lens-examples/src/main/resources/sample-cube.xml 0d97842 > > Diff: https://reviews.apache.org/r/33838/diff/ > > > Testing > ------- > > Yes. > TestCase: > mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands > > > Thanks, > > Yash Sharma > >
