----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33838/ -----------------------------------------------------------
(Updated May 21, 2015, 8:17 p.m.) Review request for lens. Changes ------- Implemented review comments. Build without all testcases - [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.089 s] [INFO] Lens ............................................... SUCCESS [ 2.653 s] [INFO] Lens API ........................................... SUCCESS [ 18.470 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 19.873 s] [INFO] Lens Cube .......................................... SUCCESS [ 42.243 s] [INFO] Lens DB storage .................................... SUCCESS [ 10.607 s] [INFO] Lens Query Library ................................. SUCCESS [ 14.298 s] [INFO] Lens Hive Driver ................................... SUCCESS [ 15.961 s] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 17.322 s] [INFO] Lens Server ........................................ SUCCESS [ 41.133 s] [INFO] Lens client ........................................ SUCCESS [ 16.587 s] [INFO] Lens CLI ........................................... SUCCESS [ 14.251 s] [INFO] Lens Examples ...................................... SUCCESS [ 11.298 s] [INFO] Lens Distribution .................................. SUCCESS [ 7.951 s] [INFO] Lens ML Lib ........................................ SUCCESS [ 22.664 s] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.940 s] [INFO] Lens Regression .................................... SUCCESS [ 8.293 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 04:31 min [INFO] Finished at: 2015-05-22T01:47:25+05:30 [INFO] Final Memory: 147M/394M [INFO] ------------------------------------------------------------------------ Complete testcase build blocked by https://issues.apache.org/jira/browse/LENS-573 Tested with functionality tests- mvn test -Dtest=TestLensFactCommands#testFactCommands mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands Repository: lens Description ------- NPE when weight is not set in XFactTable object while creating fact table Diffs (updated) ----- lens-api/src/main/resources/cube-0.1.xsd 1918e5c lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 19979cc lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java PRE-CREATION lens-cli/src/test/resources/dim-local-storage-element.xml 5a19cfa lens-cli/src/test/resources/dim_table.xml 932c975 lens-cli/src/test/resources/dim_table2.xml 1d6e138 lens-cli/src/test/resources/fact-local-storage-element.xml 8ec3b42 lens-cli/src/test/resources/fact_without_weight.xml PRE-CREATION lens-cli/src/test/resources/sample-cube-without-wt.xml PRE-CREATION lens-cli/src/test/resources/sample-cube.xml d54bcfb lens-cli/src/test/resources/test-dimension.xml d602569 lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a6651f6 lens-examples/src/main/resources/dim_table2.xml eef1513 lens-examples/src/main/resources/sample-cube.xml 0d97842 Diff: https://reviews.apache.org/r/33838/diff/ Testing ------- Yes. TestCase: mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands Thanks, Yash Sharma
