> On May 22, 2015, 4:53 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java, > > line 116 > > <https://reviews.apache.org/r/33838/diff/5/?file=966975#file966975line116> > > > > Creation still not failing? > > Yash Sharma wrote: > We ideally should not hit exception since the API only returns status > string rather than throwing exception. We can hit exception in case of > URISyntaxException. > Have enhanced the testcase to check the api response for 'failed' status > and to catch specific exception separately. > > Will be posting the new patch soon. > Please review #addFactTable
Then lets just throw the exception out since test will fail anyway. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33838/#review84865 ----------------------------------------------------------- On May 21, 2015, 8:17 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33838/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 8:17 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > NPE when weight is not set in XFactTable object while creating fact table > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 1918e5c > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 19979cc > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > PRE-CREATION > lens-cli/src/test/resources/dim-local-storage-element.xml 5a19cfa > lens-cli/src/test/resources/dim_table.xml 932c975 > lens-cli/src/test/resources/dim_table2.xml 1d6e138 > lens-cli/src/test/resources/fact-local-storage-element.xml 8ec3b42 > lens-cli/src/test/resources/fact_without_weight.xml PRE-CREATION > lens-cli/src/test/resources/sample-cube-without-wt.xml PRE-CREATION > lens-cli/src/test/resources/sample-cube.xml d54bcfb > lens-cli/src/test/resources/test-dimension.xml d602569 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > a6651f6 > lens-examples/src/main/resources/dim_table2.xml eef1513 > lens-examples/src/main/resources/sample-cube.xml 0d97842 > > Diff: https://reviews.apache.org/r/33838/diff/ > > > Testing > ------- > > Yes. > TestCase: > mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands > > > Thanks, > > Yash Sharma > >
