[
https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067948#comment-14067948
]
Mark Miller commented on SOLR-6260:
-----------------------------------
bq. the meager benefits
I think if you look at this very narrowly, perhaps it seems meager. But it's
this kind of issue that makes the code unattractive to deal with. Facilitating
the clean up for users that want to fix it will encourage those users to
contribute more. Cleaning up these fairly ugly code warts (I've particularly
been annoyed by this DirectUpdateHandler2) will also help and encourage newer
contributors.
We need to encourage and facilitate cleaning up the crap that we have always
said can't be cleaned up. If we have to compromise on some of it, fine, make it
only in 5x like we did with 4x. But let's not settle for crap because of back
compat. Back compat will sink our ship. It's important to consider, but we
can't let it strangle us. Major releases need to allow freedom to fix at a
minimum.
> Rename DirectUpdateHandler2
> ---------------------------
>
> Key: SOLR-6260
> URL: https://issues.apache.org/jira/browse/SOLR-6260
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Attachments: SOLR-6260.patch, SOLR-6260.patch
>
>
> "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2
> should be renamed, at least remove that "2". I don't know really what
> "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or
> "UpdateHandlerDefaultImpl", or other good suggestions
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
