[ 
https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067984#comment-14067984
 ] 

Yonik Seeley commented on SOLR-6260:
------------------------------------

bq. > Looking at this patch specifically, on it's own merits, it doesn't seem 
worth it to me.
bq. What does that mean?

It means that the disadvantages of this specific rename outweigh the 
advantages.  I was trying to separate this specific rename from lumping it in 
with a broader fallacy of "if we can't change this, then we can't make bigger 
changes".

Of course I fear this thread will again demonstrate Sayre's law ;-)

> Rename DirectUpdateHandler2
> ---------------------------
>
>                 Key: SOLR-6260
>                 URL: https://issues.apache.org/jira/browse/SOLR-6260
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0
>            Reporter: Tomás Fernández Löbbe
>            Priority: Minor
>         Attachments: SOLR-6260.patch, SOLR-6260.patch
>
>
> "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2 
> should be renamed, at least remove that "2". I don't know really what 
> "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or 
> "UpdateHandlerDefaultImpl", or other good suggestions



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to