[ https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067973#comment-14067973 ]
Yonik Seeley commented on SOLR-6260: ------------------------------------ bq. I've broken an insane amount of back compat stuff myself - to get major new features to work or fix broken design. Exactly... back compat is only one factor of many in these decisions. Looking at this patch specifically, on it's own merits, it doesn't seem worth it to me. As far as encouraging new users to make changes, I'd rather encourage them to make more meaningful changes. If someone wants to refactor DUH2 (or implement a new one and remove the old one), have at it! I won't stand in the way because of back compat. Maybe correctness concerns, but not back compat. > Rename DirectUpdateHandler2 > --------------------------- > > Key: SOLR-6260 > URL: https://issues.apache.org/jira/browse/SOLR-6260 > Project: Solr > Issue Type: Improvement > Affects Versions: 5.0 > Reporter: Tomás Fernández Löbbe > Priority: Minor > Attachments: SOLR-6260.patch, SOLR-6260.patch > > > "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2 > should be renamed, at least remove that "2". I don't know really what > "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or > "UpdateHandlerDefaultImpl", or other good suggestions -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org