[ 
https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987595#action_12987595
 ] 

Yonik Seeley commented on LUCENE-2883:
--------------------------------------

bq. hopefully we didnt screw this up in anyway for modules/analysis, I don't 
think Solr lost anything here.

Right, modules/analysis never concerned me since the filters moved there were 
nice and self contained, they only already relied on the lucene analysis 
interfaces, would easy to make a solr-specific copy of one if really needed in 
the future, and left some of the solr specific stuff where it was.  It all made 
sense and was a win-win.

We've hung a lot of features on function queries in Solr, and I've had plans 
for more to come - which is why it's not acceptable for it to suddenly not be a 
core part of Solr.

bq. its shared code to support both projects.

The "status" and expectations for the code are one of the big issues here - 
it's not just about the technical issues of what a patch looks like.  I would 
expect, for example, to be able to add a feature that probably only made sense 
for solr (as long as it didn't prevent lucene users from using function queries 
in general of course).  Is that acceptable to everyone?  I would not 
necessarily have the same expectation for other things in modules - it really 
depends on what it is.  Does that make sense?



> Consolidate Solr  & Lucene FunctionQuery into modules
> -----------------------------------------------------
>
>                 Key: LUCENE-2883
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2883
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Search
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0
>
>
> Spin-off from the [dev list | 
> http://www.mail-archive.com/[email protected]/msg13261.html]  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to