[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838793#comment-15838793
]
Michael McCandless commented on LUCENE-6959:
--------------------------------------------
Thanks [~martijn.v.groningen].
I think it's dangerous that we hold onto a {{LeafReader}} in the new
{{ParentChildrenBlockJoinQuery}}?
Can we maybe change the new query to instead hold the parent's docID in the
top-level reader's space, and then in the {{scorer}} method, check the incoming
reader context to see if this is the segment that holds the parent? This would
also simplify usage, so users wouldn't have to create their own weights? Then
I think you don't need the {{LeafReader}} reference.
Also, the {{TestBlockJoin}} tests got a little over decimated I think :) Can
we restore at least some of the places that were verifying children? Or maybe
we could make a simple sugar API that returns {{TopGroups}} again, and then we
wouldn't need to change the tests (except to switch to this sugar API)?
> Remove ToParentBlockJoinCollector
> ---------------------------------
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
