[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840436#comment-15840436
]
Adrien Grand commented on LUCENE-6959:
--------------------------------------
Actually scratch that last comment, that would probably make the feature too
hard to use, I think a wrapper query like you propose is better. Some
questions/comments:
- should it take the childQuery into account for equals/hashcode?
- it looks buggy to me that we do not convert {{parentDocId}} to
{{parentDocId-context.docBase}} in the scorer?
- you use ConstantScoreWeight but then return a Scorer that actually scores,
you should extend Weight directly instead.
{code}
// If parentDocId == 0 then we a parent doc doesn't have child docs
{code}
Let's remove the "we"?
> Remove ToParentBlockJoinCollector
> ---------------------------------
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch,
> LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
