[
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839570#comment-15839570
]
Michael McCandless commented on LUCENE-6959:
--------------------------------------------
bq. Mike, would just using a ScoreDoc with TopDocs be sufficient to represent a
jira issue with comments in jirasearch?
I think that's fine? I agree it would be nice to remove the dependency.
I'll have a look at the patch! Thanks for iterating.
> Remove ToParentBlockJoinCollector
> ---------------------------------
>
> Key: LUCENE-6959
> URL: https://issues.apache.org/jira/browse/LUCENE-6959
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed
> in Scorer, which are not always available (eg. disjunctions expose fake
> scorers) hence the need for a dedicated IndexSearcher
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in
> this case, I would like to remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
