[ 
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840277#comment-15840277
 ] 

Adrien Grand commented on LUCENE-6959:
--------------------------------------

I think the new query should take {{childQuery}} into account for 
equals/hashcode? This makes me wonder whether we really need to wrap the child 
query: we could just provide a query that matches all children for a given 
parent and then users could build conjunctions using BooleanQuery to decide 
what particular child documents should match?

> Remove ToParentBlockJoinCollector
> ---------------------------------
>
>                 Key: LUCENE-6959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6959
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE_6959.patch, 
> LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed 
> in Scorer, which are not always available (eg. disjunctions expose fake 
> scorers) hence the need for a dedicated IndexSearcher 
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in 
> this case, I would like to remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to