[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968836#comment-15968836
]
ASF GitHub Bot commented on LUCENE-7785:
----------------------------------------
Github user dweiss commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/187#discussion_r111553610
--- Diff:
lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/uk/UkrainianMorfologikAnalyzer.java
---
@@ -145,7 +152,7 @@ protected TokenStreamComponents createComponents(String
fieldName) {
private static Dictionary getDictionary() {
try {
- return
Dictionary.read(UkrainianMorfologikAnalyzer.class.getResource("ukrainian.dict"));
+ return
Dictionary.read(UkrainianMorfologikAnalyzer.class.getResource("/ua/net/nlp/ukrainian.dict"));
--- End diff --
This shouldn't be a class-relative read looking for an absolute resource.
Rather, I think, it should be classloader-relative
UkrainianMorfologikAnalyzer.class.getClassLoader().getResource("ua/net/nlp/ukrainian.dict").
> Move dictionary for Ukrainian analyzer to external dependency
> -------------------------------------------------------------
>
> Key: LUCENE-7785
> URL: https://issues.apache.org/jira/browse/LUCENE-7785
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Andriy Rysin
>
> Currently the dictionary for Ukrainian analyzer is a blob in the source tree.
> We should move it out to external dependency, this allows:
> * to have less binaries in the source
> * easier to update the dictionary and track updates
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
