[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969057#comment-15969057
]
ASF GitHub Bot commented on LUCENE-7785:
----------------------------------------
Github user sarowe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/187#discussion_r111574446
--- Diff: lucene/ivy-versions.properties ---
@@ -203,6 +203,8 @@ org.carrot2.morfologik.version = 2.1.1
/org.carrot2/morfologik-polish = ${org.carrot2.morfologik.version}
/org.carrot2/morfologik-stemming = ${org.carrot2.morfologik.version}
+ua.net.nlp.morfologik-ukrainian-search.version = 3.7.4
--- End diff --
This is fine, but you're missing the `/org/name=version` thing that's
required to be used in `ivy.xml` files.
If you look at the rest of this file, you can see that some `/org/name`
keys share the same version, and so a variable is introduced to simplify
maintenance. In your case, when there is only one `/org/name` key using this
version, you should IMO eliminate the
`ua.net.nlp.morfologik-ukrainian-search.version` variable entirely and add
`/ua.net.nlp/morfologik-ukrainian-search = 3.7.4`.
> Move dictionary for Ukrainian analyzer to external dependency
> -------------------------------------------------------------
>
> Key: LUCENE-7785
> URL: https://issues.apache.org/jira/browse/LUCENE-7785
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Andriy Rysin
> Assignee: Dawid Weiss
>
> Currently the dictionary for Ukrainian analyzer is a blob in the source tree.
> We should move it out to external dependency, this allows:
> * to have less binaries in the source
> * easier to update the dictionary and track updates
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
