[ https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969298#comment-15969298 ]
Steve Rowe commented on LUCENE-7785: ------------------------------------ I see that the POM for {{ua.net.nlp:morfologik-ukrainian-search:3.7.5}} adds the v2 Apache license. I hereby remove my -1. bq. Please let me know if something is still wrong. I'm pretty sure the current patch won't pass {{ant precommit}} - have you tried running that yet Andriy? There are missing files in {{lucene/licenses/}} for the new dependency: a checksum file ({{\*.sha1}}), a LICENSE file and a NOTICE file. You can generate the checksum file using {{ant jar-checksums}}, but you'll need to manually create the other two. You can create {{morfologik-ukrainian-search.LICENSE-ASL.txt}} by copying from another file in that directory that contains a clean ALv2 license, e.g. {{commons-codec-LICENSE-ASL.txt}}. I'm fuzzy on the requirements for the NOTICE file, but look at the other NOTICE files in that dir to get an idea of the range of things they contain. Some info here: [http://www.apache.org/dev/licensing-howto.html#overview-of-files] and here: [http://www.apache.org/licenses/LICENSE-2.0.html#redistribution]. > Move dictionary for Ukrainian analyzer to external dependency > ------------------------------------------------------------- > > Key: LUCENE-7785 > URL: https://issues.apache.org/jira/browse/LUCENE-7785 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Andriy Rysin > Assignee: Dawid Weiss > > Currently the dictionary for Ukrainian analyzer is a blob in the source tree. > We should move it out to external dependency, this allows: > * to have less binaries in the source > * easier to update the dictionary and track updates -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org