[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969058#comment-15969058
]
ASF GitHub Bot commented on LUCENE-7785:
----------------------------------------
Github user sarowe commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/187#discussion_r111573637
--- Diff: lucene/analysis/morfologik/ivy.xml ---
@@ -25,6 +25,7 @@
<dependency org="org.carrot2" name="morfologik-polish"
rev="${/org.carrot2/morfologik-polish}" conf="compile"/>
<dependency org="org.carrot2" name="morfologik-fsa"
rev="${/org.carrot2/morfologik-fsa}" conf="compile"/>
<dependency org="org.carrot2" name="morfologik-stemming"
rev="${/org.carrot2/morfologik-stemming}" conf="compile"/>
+ <dependency org="ua.net.nlp" name="morfologik-ukrainian-search"
rev="${ua.net.nlp.morfologik-ukrainian-search.version}" conf="compile"/>
--- End diff --
The `rev` attribute value has to be of the form `"${/org/name}"` - this
will not pass precommit. You have to make such an entry in
`ivy-versions.properties` - look at all the other examples there.
> Move dictionary for Ukrainian analyzer to external dependency
> -------------------------------------------------------------
>
> Key: LUCENE-7785
> URL: https://issues.apache.org/jira/browse/LUCENE-7785
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Andriy Rysin
> Assignee: Dawid Weiss
>
> Currently the dictionary for Ukrainian analyzer is a blob in the source tree.
> We should move it out to external dependency, this allows:
> * to have less binaries in the source
> * easier to update the dictionary and track updates
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
