Martin -
Interesting test but I couldn’t copy/paste it in to try it out as it uses some
logging and APIs that aren’t already in the project and classpath of these
lucene tests within that queries module (within IntelliJ, mind you).
I was able to resolve the misunderstanding (and .equals/.hashCode bugs) so
everything is working as expected with SpanPayloadCheckQuery for me now. Do
your tests point out an issue? Or confirming that it is working properly at a
lower level?
Erik
> On Apr 29, 2017, at 9:08 AM, Martin Gainty <mgai...@hotmail.com> wrote:
>
> Martin Gainty has shared a OneDrive file with you. To view it, click the link
> below.
>
> TestPayloadCheckQuery.java
> <https://1drv.ms/u/s!AkpuiYcNg4cSgWRHc6DadiCIYaFN>
> <https://1drv.ms/u/s!AkpuiYcNg4cSgWRHc6DadiCIYaFN>
> TestPayloadCheckQuery.java <https://1drv.ms/u/s!AkpuiYcNg4cSgWRHc6DadiCIYaFN>
> attached
>
> I coded this last nite so it is "quick and dirty"
>
> in any case let me know if testSpanPayloadCheck() method modification
> properly addresses your situation
>
> Thanks!
> Martin
> ______________________________________________
>
>
>
> From: Erik Hatcher <erik.hatc...@gmail.com>
> Sent: Saturday, April 29, 2017 8:58 AM
> To: dev@lucene.apache.org
> Subject: Re: Release 6.6
>
> Martin - there is a test class specifically for this query. See the recent
> commits I've made to test it further fixing .equals/.hashCode and rewrite.
>
> Can you send your full test code?
>
> Erik
>
> On Apr 29, 2017, at 07:32, Martin Gainty <mgai...@hotmail.com
> <mailto:mgai...@hotmail.com>> wrote:
>
>> when Erik mentioned he couldnt get SpanPayloadCheckQuery to work I was about
>> to reply just run that TestCase
>> (until i discovered there wasnt any!)
>>
>> i'll start the bidding at 1 dinar for TestCase
>> org.apache.lucene.queries.payloads.TestPayloadCheckQuery mod:
>> @org.junit.Test
>> public void testSpanPayloadCheck() throws Exception
>>
>> //now lets test the collectLeaf for query
>> //of course calling Base Class SpanPayloadCheckQuery to construct query
>>
>> log.debug("TestPayloadCheckQuery::testSpanPayloadCheck LINE 257 before
>> query.getPayloadChecker().collectLeaf((org.apache.lucene.index.PostingsEnum)postings,
>> (int)position,(org.apache.lucene.index.Term)term1) where
>> postings="+postings);
>> log.debug("TestPayloadCheckQuery::testSpanPayloadCheck LINE 258 before
>> query.getPayloadChecker().collectLeaf((org.apache.lucene.index.PostingsEnum)postings,
>> (int)position,(org.apache.lucene.index.Term)term1) where
>> position="+position);
>> log.debug("TestPayloadCheckQuery::testSpanPayloadCheck LINE 259 before
>> query.getPayloadChecker().collectLeaf((org.apache.lucene.index.PostingsEnum)postings,
>> (int)position,(org.apache.lucene.index.Term)term1) where term1="+term1);
>>
>> try
>> { //test public void collectLeaf(org.apache.lucene.index.PostingsEnum
>> postings, int position, //org.apache.lucene.index.Term term)
>> throws java.io.IOException {
>> query.getPayloadChecker().collectLeaf((org.apache.lucene.index.PostingsEnum)postings,
>> (int)position,(org.apache.lucene.index.Term)term1);
>> }
>> catch(java.io.IOException ioe) {
>> log.error("TestPayloadCheckQuery::testSpanPayloadCheck LINE 264
>> query.getPayloadChecker().collectLeaf((org.apache.lucene.index.PostingsEnum)postings,
>> (int)position,(org.apache.lucene.index.Term)term1) LINE 106 throws
>> IOException ="+ioe.getMessage()); }
>>
>> unless of course anyone has a better idea to test collectLeaf ?
>> Martin
>> ______________________________________________
>>
>>
>>
>> From: Erik Hatcher <erik.hatc...@gmail.com <mailto:erik.hatc...@gmail.com>>
>> Sent: Tuesday, April 25, 2017 7:57 PM
>> To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
>> Subject: Re: Release 6.6
>>
>> Probably no bribe needed, but an updated patch would be a good start (or
>> will the 2.5 year old patch still apply and be acceptable as-is?)
>>
>> Erik
>>
>>> On Apr 25, 2017, at 7:52 PM, Walter Underwood <wun...@wunderwood.org
>>> <mailto:wun...@wunderwood.org>> wrote:
>>>
>>> Who do I have to bribe to get SOLR-629 included?
>>>
>>> https://issues.apache.org/jira/browse/SOLR-629
>>> <https://issues.apache.org/jira/browse/SOLR-629>
>>>
>>> wunder
>>> Walter Underwood
>>> wun...@wunderwood.org <mailto:wun...@wunderwood.org>
>>> http://observer.wunderwood.org/ <http://observer.wunderwood.org/> (my blog)
>>>
>>>
>>>> On Apr 25, 2017, at 10:46 AM, Ishan Chattopadhyaya
>>>> <ichattopadhy...@gmail.com <mailto:ichattopadhy...@gmail.com>> wrote:
>>>>
>>>> Hi,
>>>> We have lots of changes, optimizations, bug fixes for 6.6. I'd like to
>>>> propose a 6.6 release (perhaps the last 6x non-bug-fix release before 7.0
>>>> release).
>>>>
>>>> I can volunteer to release this, and I can cut the release branch around
>>>> 4th May, in order to let some time for devs to finish current issues.
>>>>
>>>> What do you think?
>>>>
>>>> Regards,
>>>> Ishan
