[ 
https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-3147:
-------------------------------

    Attachment: LUCENE-3147.patch

Patch against trunk fixes MockDirWrapper to track open files of both II and IO. 
Also, I've made the maps private and added methods for removing and 
IndexInput/Output.

One test that fails (previously failed to delete dir, when FSDirectory was 
used):
{noformat}
NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterWithThreads 
-Dtestmethod=testIOExceptionDuringWriteSegmentWithThreads 
-Dtests.seed=2215506388922451011:4021053174950346200
NOTE: test params are: codec=RandomCodecProvider: 
{field=MockFixedIntBlock(blockSize=6)}, locale=el_CY, timezone=Europe/Volgograd
NOTE: all tests run in this JVM:
[TestIndexWriterWithThreads]
NOTE: Windows 7 6.1 build 7600 amd64/IBM Corporation 1.6.0 
(64-bit)/cpus=2,threads=4,free=37703064,total=48524288
{noformat}

I'm sure there are other tests too. I'll try to find a non-threaded one.

> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-3147
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3147
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: general/test
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only. 
> Therefore IO files that are not closed do not fail our tests, which can then 
> lead to test directories fail to delete on Windows. We should make sure all 
> open files are tracked and if they are left open, fail the test. I'll attach 
> a patch shortly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to