[
https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040189#comment-13040189
]
Shai Erera commented on LUCENE-3147:
------------------------------------
bq. In BlockTermsWriter, the "success" boolean is never set to true!
Good catch. Fixed !
bq. for readability:
Sure, I'll change
bq. I wonder if we should rather add a boolean to IOUtils.closeSafely
I didn't want to do that since it's public API, and I intend to backport these
changes to 3x. But I can add another closeSafely variant as you suggest, and
have the current one call it w/ false?
Also, I think that closeSafely isn't really safe :). If RuntimeException is
thrown, the code will blow away, not closing all Closeables. We need to fix
that as well. (I'm not sure, but I think some Faliure objects throw
RuntimeException during close() ...
> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
> Key: LUCENE-3147
> URL: https://issues.apache.org/jira/browse/LUCENE-3147
> Project: Lucene - Java
> Issue Type: Test
> Components: general/test
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only.
> Therefore IO files that are not closed do not fail our tests, which can then
> lead to test directories fail to delete on Windows. We should make sure all
> open files are tracked and if they are left open, fail the test. I'll attach
> a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
