[
https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040295#comment-13040295
]
Uwe Schindler edited comment on LUCENE-3147 at 5/27/11 3:54 PM:
----------------------------------------------------------------
Can we also add a closeSafely & others taking Iterable<Closeable> instead of
varargs/array? When you fix more leaks, there may be more places where
collections may be used, so it would be a nice addition.
I am refering to the one place in your code where you added a comment, that
closeSafely only takes arrays and you had to duplicate the code.
was (Author: thetaphi):
Can we also add a closeSafely & others taking Iterable<Closeable> instead
of varargs/array? When you fix more leaks, there may be more places where
collections may be used, so it would be a nice addition.
> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
> Key: LUCENE-3147
> URL: https://issues.apache.org/jira/browse/LUCENE-3147
> Project: Lucene - Java
> Issue Type: Test
> Components: general/test
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch,
> LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only.
> Therefore IO files that are not closed do not fail our tests, which can then
> lead to test directories fail to delete on Windows. We should make sure all
> open files are tracked and if they are left open, fail the test. I'll attach
> a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
