[
https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039697#comment-13039697
]
Simon Willnauer commented on LUCENE-3147:
-----------------------------------------
Shai I have a couple of comments
* first good catch! :)
* reenable the FIXME is awesome
* in DefaultSegmentInfosWriter you might want to change the try / catch blocks
to a simple try / finally if (!succes) out.close(); for simplicity
* in MockDirectoryWrapper#addFileHandle(io, name) you create an exception that
always says "Unclosed IndexInput" which should say IndexOutput if the handle is
an index output. I think this could be very confusing if you run into bugs
there.
simon
> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
> Key: LUCENE-3147
> URL: https://issues.apache.org/jira/browse/LUCENE-3147
> Project: Lucene - Java
> Issue Type: Test
> Components: general/test
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3147.patch, LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only.
> Therefore IO files that are not closed do not fail our tests, which can then
> lead to test directories fail to delete on Windows. We should make sure all
> open files are tracked and if they are left open, fail the test. I'll attach
> a patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
