[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152709#comment-16152709
]
Ignacio Vera commented on LUCENE-7951:
--------------------------------------
Thanks for the comments! please feel free to add more as tomorrow I will have
a couple of hours tomorrow to put as many as possible together.
Regarding the shape suffix for points: It is there for two reasons: 1) There is
already a Geo3DPoint in spatial3d package and I didn't like the class to have a
similar name 2) There is always a conflic between a point being a component of
shape (~ GeoPoint) and a point behaving like a shape. I thought in this case it
stress the functionality of the class. But if you feel that it is better to
remove the suffix I do not feel so strong about it.
Regarding the distance calculator: I implemented this way because I felt it
should work for any planet model. In my particular use case, I am using an
external function because I need point-shape distance which is supported in
Geo3d but not in Spatial4j. I am ok letting the default one although still
exact calculations might be useful regardless the performance penalty for some
users.
> New wrapper classes for Geo3d
> -----------------------------
>
> Key: LUCENE-7951
> URL: https://issues.apache.org/jira/browse/LUCENE-7951
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
> Priority: Minor
> Attachments: LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to
> Solr as they implement their own SpatialContextFactory. It provides the
> capability of indexing shapes with
> spherical geometry.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
