[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156949#comment-16156949
]
David Smiley commented on LUCENE-7951:
--------------------------------------
I think Geo3d randomized shape generation should exist in one place, in it's
test classpath somewhere. Now is a great time to do that. If precommit or
the build otherwise complains, we can probably figure that out; I'll look
closer at such possible errors if you move it there.
Perhaps the Spatial4j integration should imply "GeoArea". I don't think we
need two base shape implementations. Likewise, perhaps just one test, merging
in the tests from the one you developed and the existing one. The ability to
"intersect" two Shapes is fundamental to the assumptions of Spatial4j, and thus
Geo3d's "GeoAreaShape" is required, I think.
> New wrapper classes for Geo3d
> -----------------------------
>
> Key: LUCENE-7951
> URL: https://issues.apache.org/jira/browse/LUCENE-7951
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to
> Solr as they implement their own SpatialContextFactory. It provides the
> capability of indexing shapes with
> spherical geometry.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
