[ 
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156557#comment-16156557
 ] 

Ignacio Vera commented on LUCENE-7951:
--------------------------------------

[~dsmiley], I am ok with the pull request but I have never done it so I am 
trying to figure out how to do it. 

GeoAreaShapes know how to relate spatially with other shapes, Geoshape do not 
need to. Current generated shapes from Spatial4j can relate spatially. The 
question here is if we are keeping the current Geo3dShape implementation or we 
override it with this new version.

RandomGeoShapeGenerator was originally developed to test spatial relationships 
between GeoAreaShapes. There is currently two versions, one in spatial-3d test 
and one in spatial-extras-test. I don't know if I am missing something but I 
had to copy the class or precommit will complain. Unfortunately, there are now 
slightly difference but I think we should only have one class that can be 
referenced. 



> New wrapper classes for Geo3d
> -----------------------------
>
>                 Key: LUCENE-7951
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7951
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships 
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of 
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to 
> Solr as they implement their own SpatialContextFactory. It provides the 
> capability of indexing shapes with 
>  spherical geometry.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to