[ 
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173118#comment-16173118
 ] 

Karl Wright commented on LUCENE-7951:
-------------------------------------

{quote}
The test generates points of a shape by creating a circle and generating points 
using a distance (lower than the radius) and bearing angle from the center of 
the circle. After creating the point it checks that the generated point is 
inside the circle and if it doesn't it fails.
{quote}

[~ivera] It sounds like the test should expect deviation within a certain 
(computed) error range from a true circle.  I think it's possible to compute 
the actual error by the following process:
(1) From the center, with the Vincenti formula compute the "actual" top 
latitude of the circle, the bottom latitude of the circle, and either the left 
or right latitude of the circle.
(2) Compute the lat/lon bounds of the comparable GeoStandardCircle
(3) Compute the difference between those bounds and the Vincenti-computed bounds

As for what the theoretical error is, I will have to do some math and get back 
to you on that.  But we would want the error to at least be reasonably 
symmetrical (that is, not significantly larger at the top of the circle than at 
the bottom), etc.  What do you think?

> New wrapper classes for Geo3d
> -----------------------------
>
>                 Key: LUCENE-7951
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7951
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE_7951_build.patch, LUCENE_7951_build.patch, 
> LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships 
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of 
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to 
> Solr as they implement their own SpatialContextFactory. It provides the 
> capability of indexing shapes with 
>  spherical geometry.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to