[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171100#comment-16171100 ]
David Smiley commented on LUCENE-7951: -------------------------------------- (I'm back from travel) The current state is looking pretty nice. I think you can now merge Geo3dAreaRptTest into Geo3dRptTest? Keep the specific tests for bugs that were found. Use the new random shape generator instead of the manual code. bq. Geo3dCircleShape.relate While I don't pretend to know the details of the algorithms for both world models, I do find the override of the method here a bit suspicious. Shouldn't GeoStandardCircle look at the PlanetModel and do the right thing? bq. New constructor in Geo3dRectangleShape Ok. > New wrapper classes for Geo3d > ----------------------------- > > Key: LUCENE-7951 > URL: https://issues.apache.org/jira/browse/LUCENE-7951 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras > Reporter: Ignacio Vera > Assignee: David Smiley > Priority: Minor > Attachments: LUCENE_7951_build.patch, LUCENE_7951_build.patch, > LUCENE-7951.patch, LUCENE-7951.patch > > > Hi, > After the latest developments in the Geo3d library, in particular: > [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships > between GeoShapes > [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of > GeoShapes. > I propose a new set of wrapper classes which can be for example linked to > Solr as they implement their own SpatialContextFactory. It provides the > capability of indexing shapes with > spherical geometry. > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org