[
https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296907#comment-16296907
]
David Smiley commented on LUCENE-8104:
--------------------------------------
bq. Removing ValueSource entirely would be great, but it's heavily used within
Solr. Would you want to just move the classes into the Solr subproject, or try
and rework things so that Solr uses DoubleValuesSource instead?
Indeed those are the options. The latter is certainly preferable to me but is
of course a lot of work -- not sure how much.
RE facets module: if its tests only depend on the queries module then the
build/dependencies should be modified as-such (or as Adrien suggested use
FunctionScoreQuery. And have its test switch to FunctionScoreQuery (thus
_away_ from ValueSource framework). Right now the facets module artificially
declares through its dependencies that a user needs the queries module when
that's not true. This ought to be another issue; sorry for distracting us here.
> Grouping module should no longer depend on Queries module (ValueSource)
> -----------------------------------------------------------------------
>
> Key: LUCENE-8104
> URL: https://issues.apache.org/jira/browse/LUCENE-8104
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/grouping
> Reporter: David Smiley
> Attachments: LUCENE-8104.patch
>
>
> The Grouping module depends on the Queries module in GroupingSearch /
> ValueSourceGroupSelector to use the ValueSource framework. It should instead
> use the newer DoubleValueSource or LongValueSource framework in Core. As I
> write this, this appears to be the last part of Lucene to refer to the
> ValueSource framework, and I think we should then remove it -- for another
> issue of course.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
