[
https://issues.apache.org/jira/browse/LUCENE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057792#comment-13057792
]
Robert Muir commented on LUCENE-3264:
-------------------------------------
{quote}
Previously the tests took 1m20s to run, now they take 2m55s. I guess it's
because previously we only created RAMDirs, while now newDirectory picks FSDir
from time to time (10%?).
{quote}
I don't think its from FSDir, this is now very very rarely picked. Anyway, as
said in the issue summary, for a number of reasons, I don't want to address
this on this issue, I want to address the coverage first.
{quote}
FacetTestUtils.close*() can be removed and calls replaced by
IOUtils.closeSafely. This is not critical, just remove redundant code.
{quote}
ah, you are right. let's change this.
{quote}
You added a TODO to CategoryListIteratorTest about the test failing if TieredMP
is used. In general TieredMP is not good for the taxonomy index, which relies
on Lucene doc IDs, and therefore segments must be merged in-order. LTW uses LMP
specifically because of that. I will look into the test to understand why would
it care about doc IDs, since it doesn't using the taxonomy index at all.
{quote}
Right, as you said this is for the main index, not the taxonomy index. So I
think the test just relies upon lucene doc ids, but I didnt want to just change
the test without saying why.
{quote}
There are few places with code like: assertTrue("Would like to test this with
deletions!",indexReader.hasDeletions()), and assertTrue("Would like to test
this with deletions!",indexReader.numDeletedDocs() > 0) which you removed. Any
reason?
{quote}
Mostly to prevent the tests from failing. RandomIndexWriter randomly optimizes
some times, so occasionally there are no deletions. I think this is fine
(actually better) as far as coverage... then the deleted docs is occasionally
null, etc.
{quote}
You added a TODO to TestScoredDocIDsUtils (about reader is read-only) – you're
right, the comment can be deleted.
{quote}
OK, I'll nuke this.
{quote}
We can add RandomTaxonomyWriter as a follow-on commit.
{quote}
Yes, lets do this separate.
> crank up faceting module tests
> ------------------------------
>
> Key: LUCENE-3264
> URL: https://issues.apache.org/jira/browse/LUCENE-3264
> Project: Lucene - Java
> Issue Type: Test
> Components: modules/facet
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.4, 4.0
>
> Attachments: LUCENE-3264.patch
>
>
> The faceting module has a large set of good tests.
> lets switch them over to use all of our test infra (randomindexwriter, random
> iwconfig, mockanalyzer, newDirectory, ...)
> I don't want to address multipliers and atLeast() etc on this issue, I think
> we should follow up with that on a separate issue, that also looks at speed
> and making sure the nightly build is exhaustive.
> for now, lets just get the coverage in, it will be good to do before any
> refactoring.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
