[
https://issues.apache.org/jira/browse/LUCENE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057901#comment-13057901
]
Robert Muir commented on LUCENE-3264:
-------------------------------------
{quote}
I don't understand. I thought that you said so regarding introducing atLeast
and iterations, and I'm ok with that. I was just asking, since all you've done
is move to use newDir, newIWC and RandomIW, how come the tests running time got
that much longer? If it's not FSDir, do you have any idea what can cause that?
Will RandomIW stall indexing randomly, or maybe it's newIWC which chooses to
flush more often?
{quote}
I think the slowdown is basically linear (the tests run 2x or 3x as slow). Let
me explain some of the reasons why you have this slowdown over just normal
indexing without using randomiw/mockdirectorywrapper/etc:
# we call checkIndex on every directory we create after its closed. I think
this is the right thing to do always... it does slow down the tests a bit.
# we do sometimes get crappy indexing params, crazy merge params, ridiculous
IndexReader/Writer params (e.g. termIndexInterval=1). I think sometimes these
non-optimal params slow things down.
# occasionally we do things like randomly fully or partially optimize, yield(),
etc.
So while Lucene's defaults are pretty good, we are testing a bunch of
non-default parameters and doing a bunch of other crazy things... so these slow
down the tests!
That being said, I'm working on the speed issue at least a little here, because
I really want to get this test improvements in, although I really didn't want
to work on this here (I think 1 minute extra *temporarily* to the build is no
big deal for the additional coverage).
> crank up faceting module tests
> ------------------------------
>
> Key: LUCENE-3264
> URL: https://issues.apache.org/jira/browse/LUCENE-3264
> Project: Lucene - Java
> Issue Type: Test
> Components: modules/facet
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.4, 4.0
>
> Attachments: LUCENE-3264.patch
>
>
> The faceting module has a large set of good tests.
> lets switch them over to use all of our test infra (randomindexwriter, random
> iwconfig, mockanalyzer, newDirectory, ...)
> I don't want to address multipliers and atLeast() etc on this issue, I think
> we should follow up with that on a separate issue, that also looks at speed
> and making sure the nightly build is exhaustive.
> for now, lets just get the coverage in, it will be good to do before any
> refactoring.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
