[
https://issues.apache.org/jira/browse/LUCENE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057893#comment-13057893
]
Shai Erera commented on LUCENE-3264:
------------------------------------
bq. Anyway, as said in the issue summary, for a number of reasons, I don't want
to address this on this issue, I want to address the coverage first.
I don't understand. I thought that you said so regarding introducing atLeast
and iterations, and I'm ok with that. I was just asking, since all you've done
is move to use newDir, newIWC and RandomIW, how come the tests running time got
that much longer? If it's not FSDir, do you have any idea what can cause that?
Will RandomIW stall indexing randomly, or maybe it's newIWC which chooses to
flush more often?
Only trying to understand the cause here.
bq. RandomIndexWriter randomly optimizes some times, so occasionally there are
no deletions
Ok, makes sense.
bq. So I think the test just relies upon lucene doc ids, but I didnt want to
just change the test without saying why.
I'll dig why, but it shouldn't hold up the issue. If it needs to be changed, we
can change it later.
> crank up faceting module tests
> ------------------------------
>
> Key: LUCENE-3264
> URL: https://issues.apache.org/jira/browse/LUCENE-3264
> Project: Lucene - Java
> Issue Type: Test
> Components: modules/facet
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 3.4, 4.0
>
> Attachments: LUCENE-3264.patch
>
>
> The faceting module has a large set of good tests.
> lets switch them over to use all of our test infra (randomindexwriter, random
> iwconfig, mockanalyzer, newDirectory, ...)
> I don't want to address multipliers and atLeast() etc on this issue, I think
> we should follow up with that on a separate issue, that also looks at speed
> and making sure the nightly build is exhaustive.
> for now, lets just get the coverage in, it will be good to do before any
> refactoring.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
