[ https://issues.apache.org/jira/browse/LUCENE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057906#comment-13057906 ]
Shai Erera commented on LUCENE-3264: ------------------------------------ Thanks Robert. This makes sense to me. bq. although I really didn't want to work on this here (I think 1 minute extra temporarily to the build is no big deal for the additional coverage) I apologize if that caused you to do that work here. I really only wanted to understand. By all means, commit the changes. The explanation makes sense and I'm ok with it. We can speed up things later. > crank up faceting module tests > ------------------------------ > > Key: LUCENE-3264 > URL: https://issues.apache.org/jira/browse/LUCENE-3264 > Project: Lucene - Java > Issue Type: Test > Components: modules/facet > Reporter: Robert Muir > Assignee: Robert Muir > Fix For: 3.4, 4.0 > > Attachments: LUCENE-3264.patch, LUCENE-3264.patch > > > The faceting module has a large set of good tests. > lets switch them over to use all of our test infra (randomindexwriter, random > iwconfig, mockanalyzer, newDirectory, ...) > I don't want to address multipliers and atLeast() etc on this issue, I think > we should follow up with that on a separate issue, that also looks at speed > and making sure the nightly build is exhaustive. > for now, lets just get the coverage in, it will be good to do before any > refactoring. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org