Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228197896
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -609,9 +618,10 @@ public static SolrInputDocument
getInputDocument(SolrCore core, BytesRef idBytes
* @param resolveFullDocument In case the document is fetched from the
tlog, it could only be a partial document if the last update
* was an in-place update. In that case, should this
partial document be resolved to a full document (by following
* back prevPointer/prevVersion)?
+ * @param resolveBlock Check whether the document is part of a block. If
so, return the whole block.
*/
public static SolrInputDocument getInputDocument(SolrCore core, BytesRef
idBytes, AtomicLong versionReturned, boolean avoidRetrievingStoredFields,
- Set<String> onlyTheseNonStoredDVs, boolean resolveFullDocument)
throws IOException {
+ Set<String> onlyTheseNonStoredDVs, boolean resolveFullDocument,
boolean resolveBlock) throws IOException {
SolrInputDocument sid = null;
--- End diff --
@moshebla I'm concerned about this method having so many parameters... it's
a code smell.
resolveBlock & resolveChildren booleans... not sure how they differ. Isn't
resolveChildren enough? if resolveChildren true, then isn't effectively
resolveFullDocument also true? (if so the constraint could be documented and
enforced with an assertion).
versionReturned is a dubious parameter I'm skeptical needs to be here. I'm
aware you didn't add it, but the number of parameters is getting troublingly
long with your changes; it's good to review what's needed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
