Github user dsmiley commented on the issue:

    https://github.com/apache/lucene-solr/pull/528
  
    * DUP.postProcessAdd's javadoc is confusing; maybe drop it.  It says "This 
method can be overridden to tamper with the cmd" but I'm looking at where we 
override it and I don't see any tampering to this.updateCommand.
    * DUP: Lets remove the Standalone subclass in favor of making the base 
class do the standalone functionality; I think it's not really doing much of 
anything other than relying on the base impl.  There's practically no 
functionality (real code) in the standalone class right now so it's kind of 
pointless.
    * DistributedZkUpdateProcessor's constructor that takes a docMerger isn't 
called externally so lets have just one constructor


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to