Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/528
> It'd be excellent if we could get some consistency of calling
setupRequest -- all processXXX methods should first call setupRequest and if
needed an overloaded variant.
Perhaps we'd have to rename DUP#processDelete, since it only routes the
DeleteUpdateCommand to DUP#doDeleteById or DUP#doDeleteByQuery, the latter
having a unique logic is is different to setupRequest.
Another option would be to check what type of UpdateCommand is passed to
DUP#setupRequest, but that would mean there might be some duplication of
DeleteUpdateCommand checks in DistributedUpdateCommandProcessor and
DistributedZkUPdateProcessor.
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
