Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/528
* DUP.next can be removed as it's redundant with the same in the superclass
* DUP.MAX_RETRIES_TO_FOLLOWERS_DEFAULT you accidentally added an 'R' to the
** of the javadoc.
* DUP.isLeader method ought to go after the constructor. Generally, the
constructor goes before instance methods.
* DUP.isIndexChanged() remove this method; strictly internal and it's
inconsistent with the fact that there are many fields that don't have
accessors, so why should this one.
* DUP.versionAdd shouldClone: I think it would be a little simpler to have
the second conditional to "shouldClone" instead check if clonedDoc != null. At
that point you will only have one var reference to shouldClone and you could
inline it to how you initialize it.
* DUP.postProcessAdd: I think this method would be better named doDistribAdd
* Maybe we can avoid DistributedZkUpdateProcessor overriding processAdd.
Somehow checkReplicationTracker() needs to get called. One way to do this
would be for setupRequest to check if the updateCommand is an instance of
AddUpdateCommand)).
* It'd be excellent if we could get some consistency of calling
setupRequest -- all processXXX methods should first call setupRequest and if
needed an overloaded variant.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
