Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/528
Man this is a tangled mess we are trying to unravel! I wish someone
undertook this years ago.
Lets not rename DUP#processDelete as it is an URP defined method we
override, and I doubt it'd worth it to expand the change to URP.
postProcessDeleteByQuery can be renamed to doDistribDeleteByQuery, and
postProcessDeleteById can be renamed doDistribDeleteById.
The flow of doDeleteById & doDeleteByQuery are different, which is a bit
annoying. It's hard for me to make much sense of it right now. I know the ZK
version entirely overrides processCommit but I think there the flow was more
clear, at least to me. But on the delete side, I find it confusing that the ZK
version overrides doDeleteByQuery. ... gotta go for now
Let me know when you're done with the issue and I can try some thing too.
It's such a time sink unfortunately.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
