[
https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186315#comment-13186315
]
Robert Muir commented on LUCENE-3687:
-------------------------------------
I think otherwise the patch is great.
we really needed to split out fieldinfos implementations for 3.x and 4.x, for
example
this will be useful to support offsets in the postings lists for lucene4xcodec
(LUCENE-3684)
a few minor/trivial comments:
in PreFlexRW and SimpleText's impl:
throw new IllegalArgumentException("Codec only supports single byte norm
values. Type give: " + type);
I think this should be UOE?
shouldn't we combine Norm and DocValueNorm into one final class (Norm) and pull
it out of Sim?
I don't think it needs to be inside Sim anymore, as I don't see any usefulness
to making your own
subclass (how will this affect scoring versus just using the DocValueNorm impl)
Is there any other use case to Norm being abstract? iff there is, shouldnt
normsconsumer[perfield] pull the impl from the codec?
> Allow similarity to encode norms other than a single byte
> ---------------------------------------------------------
>
> Key: LUCENE-3687
> URL: https://issues.apache.org/jira/browse/LUCENE-3687
> Project: Lucene - Java
> Issue Type: New Feature
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3687.patch, LUCENE-3687.patch, LUCENE-3687.patch
>
>
> LUCENE-3628 cut over norms to docvalues. This removes the long standing
> limitation that norms are a single byte. Yet, we still need to expose this
> functionality to Similarity to write / encode norms in a different format.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
