[
https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186638#comment-13186638
]
Michael McCandless commented on LUCENE-3687:
--------------------------------------------
This looks great! I love how you pass Norm to the sim and it sets
what it wants...
Hmm... Norm impls DocValue which I just removed... maybe we should add
it back?
Very nice to have a private 3x FieldInfos reader/writer!
What happens if an app (incorrectly) tries to change up the normType
suddenly...? If you change in the middle of an IW session... it's
quietly ignored and you get 0/empty bytes indexed instead?
(FieldInfo.setNormValueType silently does nothing if it's already
set). Can we throw an exception if it's already set to a conflicting
value?
If you change on a new IW session... they will be merged according to
the normal type promotion rules of doc values right?
Maybe instead of set and reset methods on FieldInfo just have a single
set method with force boolean?
This fails for me:
{noformat}
[junit] Testsuite: org.apache.solr.search.function.TestFunctionQuery
[junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.939 sec
[junit]
[junit] ------------- Standard Error -----------------
[junit] NOTE: reproduce with: ant test -Dtestcase=TestFunctionQuery
-Dtestmethod=testGeneral
-Dtests.seed=-406004cdb5fb0321:-4f9a2e7a9fa49aa4:7de466246285c0e9
-Dargs="-Dfile.encoding=UTF-8"
[junit] NOTE: test params are: codec=Lucene40: {},
sim=RandomSimilarityProvider(queryNorm=true,coord=true): {}, locale=ro,
timezone=Europe/Malta
[junit] NOTE: all tests run in this JVM:
[junit] [TestFunctionQuery]
[junit] NOTE: Linux 2.6.33.6-147.fc13.x86_64 amd64/Sun Microsystems Inc.
1.6.0_21 (64-bit)/cpus=24,threads=1,free=171062240,total=239534080
[junit] ------------- ---------------- ---------------
[junit] Testcase:
testGeneral(org.apache.solr.search.function.TestFunctionQuery): Caused an
ERROR
[junit] null
[junit] java.lang.NullPointerException
[junit] at
org.apache.solr.search.function.TestFunctionQuery.testGeneral(TestFunctionQuery.java:352)
[junit] at
org.apache.lucene.util.LuceneTestCase$3$1.evaluate(LuceneTestCase.java:528)
[junit] at
org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:165)
[junit] at
org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:57)
{noformat}
> Allow similarity to encode norms other than a single byte
> ---------------------------------------------------------
>
> Key: LUCENE-3687
> URL: https://issues.apache.org/jira/browse/LUCENE-3687
> Project: Lucene - Java
> Issue Type: New Feature
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3687.patch, LUCENE-3687.patch, LUCENE-3687.patch,
> LUCENE-3687.patch
>
>
> LUCENE-3628 cut over norms to docvalues. This removes the long standing
> limitation that norms are a single byte. Yet, we still need to expose this
> functionality to Similarity to write / encode norms in a different format.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
