[ 
https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186320#comment-13186320
 ] 

Robert Muir commented on LUCENE-3687:
-------------------------------------

Two more questions:

In the patch omitNorms is still a separate boolean from normValueType == null.
If this is the case, aren't we now able to represent (in 4.x codec) that norms 
are not omitted for the field,
they just don't exist at all (e.g. all documents without norms are deleted).
Couldn't we take advantage of this to provide a true fix for LUCENE-3678, 
removing the bogus fileExists() stuff in NormsFormat's files()?

What happens if a sim doesnt ever set anything in computeNorm at all for a 
field? 
Previously this was 'required' because the method required that you return a 
byte.
I think, if we do the above and are able to separately represent 'doesnt hvae 
any norms for this segment' 
from 'omitNorms for this field always', that we would just have normValueType 
as null, and it would all just work?

                
> Allow similarity to encode norms other than a single byte
> ---------------------------------------------------------
>
>                 Key: LUCENE-3687
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3687
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: core/index, core/search
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3687.patch, LUCENE-3687.patch, LUCENE-3687.patch
>
>
> LUCENE-3628 cut over norms to docvalues. This removes the long standing 
> limitation that norms are a single byte. Yet, we still need to expose this 
> functionality to Similarity to write / encode norms in a different format. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to