[
https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-3687:
------------------------------------
Attachment: LUCENE-3687.patch
here is a new patch with changes.txt and more tests for cases where norms are
not written but also not omitted.
all tests pass, I think this is ready though!
bq. Hmm... Norm impls DocValue which I just removed... maybe we should add it
back?
I used DocValuesField as a delegate in this patch. I don't think we need this
interface at this point.
{quote}
What happens if an app (incorrectly) tries to change up the normType
suddenly...? If you change in the middle of an IW session... it's quietly
ignored and you get 0/empty bytes indexed instead? {quote}
there is a test for this in TestCustomNorms (testExceptionOnRandomType) it
throws a IAE in NormsConsumerPerField.
{quote}(FieldInfo.setNormValueType silently does nothing if it's already
set). Can we throw an exception if it's already set to a conflicting
value?{quote}
I added some logic in there to throw an exc if it is not forced and the value
!= null.
{quote} If you change on a new IW session... they will be merged according to
the normal type promotion rules of doc values right? {quote}
right!
{quote}Maybe instead of set and reset methods on FieldInfo just have a single
set method with force boolean?{quote}
done! I also added some sugar to FieldInfo to check if the norms are present.
bq. This fails for me:
fixed my fault
> Allow similarity to encode norms other than a single byte
> ---------------------------------------------------------
>
> Key: LUCENE-3687
> URL: https://issues.apache.org/jira/browse/LUCENE-3687
> Project: Lucene - Java
> Issue Type: New Feature
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3687.patch, LUCENE-3687.patch, LUCENE-3687.patch,
> LUCENE-3687.patch, LUCENE-3687.patch
>
>
> LUCENE-3628 cut over norms to docvalues. This removes the long standing
> limitation that norms are a single byte. Yet, we still need to expose this
> functionality to Similarity to write / encode norms in a different format.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
