[ 
https://issues.apache.org/jira/browse/LUCENE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208298#comment-13208298
 ] 

Shai Erera commented on LUCENE-3760:
------------------------------------

The method that you proposes is not very efficient -- why do I need to list all 
commits just to retrieve the latest's commitData?

bq. By the way: Why is the return value of listCommits() 
Collection<IndexCommit> and not List<IndexCommit>

It is like that for API back-compat. The return value of a method is part of 
its signature. I don't remember on which issue, but I wanted to do that once, 
and discovered that it breaks either the backwards tests, or current running 
code (with the new .jar). That's why the method documents that in practice it 
returns a sorted List.
                
> Cleanup DR.getCurrentVersion/DR.getUserData/DR.getIndexCommit().getUserData()
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-3760
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3760
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3760.patch, LUCENE-3760.patch
>
>
> Spinoff from Ryan's dev thread "DR.getCommitUserData() vs 
> DR.getIndexCommit().getUserData()"... these methods are confusing/dups right 
> now.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to