[ https://issues.apache.org/jira/browse/LUCENE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208335#comment-13208335 ]
Shai Erera commented on LUCENE-3760: ------------------------------------ You mean if IndexReader.getCommitUserData() is faster than IndexReader.open().getIndexCommit().getUserData()? Do I really need to benchmark this !? The static method just reads the SegmentInfos and returns the commitData. Opening an IndexReader at least opens its all sub-segments, loads norms, deleted docs and what not. Look, it's not like I'm trying to add a new API. It existed for a long time, and it happens to be that I'm using it (and maybe others who didn't speak up). So why deprecate it? I'm also using it in the SearcherTaxoManager (not yet uploaded to LUCENE-3786) to inspect the commit data on the taxonomy directory before I create a new DirTaxoReader, which is very expensive. So why nuke it? > Cleanup DR.getCurrentVersion/DR.getUserData/DR.getIndexCommit().getUserData() > ----------------------------------------------------------------------------- > > Key: LUCENE-3760 > URL: https://issues.apache.org/jira/browse/LUCENE-3760 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3760.patch, LUCENE-3760.patch > > > Spinoff from Ryan's dev thread "DR.getCommitUserData() vs > DR.getIndexCommit().getUserData()"... these methods are confusing/dups right > now. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org