[ 
https://issues.apache.org/jira/browse/LUCENE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208317#comment-13208317
 ] 

Shai Erera commented on LUCENE-3760:
------------------------------------

bq. But we can change that in 4.0?

Yes, in 4.0, DirReader.listCommits returns List<>.

bq. If you only have 1 commit it does not matter.

Yes, that's right. But I cannot guarantee that (because we sometimes maintain 
few index commits). What's wrong with just undeprecating the method? It's not 
like it was deprecated for technical reasons. As said above, nobody thought of 
a useful scenario to use it, so it was deprecated. But I have a useful scenario.

Do you agree that I simply undeprecate them?
                
> Cleanup DR.getCurrentVersion/DR.getUserData/DR.getIndexCommit().getUserData()
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-3760
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3760
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3760.patch, LUCENE-3760.patch
>
>
> Spinoff from Ryan's dev thread "DR.getCommitUserData() vs 
> DR.getIndexCommit().getUserData()"... these methods are confusing/dups right 
> now.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to