[ 
https://issues.apache.org/jira/browse/LUCENE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Willnauer updated LUCENE-3807:
------------------------------------

    Attachment: LUCENE-3807.patch

next patch...
 * cut over Lookup API to use CharSequence instead of string. this allows us to 
use CharsRef and saves object creation.
* removed Sorted marker interface. BytesRefIterator has a getComparator() that 
can be null to indicate that there is no specified sort order. That way we can 
compare the Comparator<BytesRef> instance to see if the sort order matches what 
the impl expects.
* added a IOException to Dictionary#getWordsIterator() removing tons of 
try/catch throw RTE
* renamed freq to weight
* weight (ie freq) now returns a long instead of a float discouraging floating 
point number as weights

next steps would be cleaning up the in-memory sorting stuff and use the sorter 
which goes to disk to do the actual sorting internally if needed

comments welcome
                
> Cleanup suggester API
> ---------------------
>
>                 Key: LUCENE-3807
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3807
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/other
>    Affects Versions: 3.6, 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3807.patch, LUCENE-3807.patch
>
>
> Currently the suggester api and especially TermFreqIterator don't play that 
> nice with BytesRef and other paradigms we use in lucene, further the java 
> iterator pattern isn't that useful when it gets to work with TermsEnum, 
> BytesRef etc. We should try to clean up this api step by step moving over to 
> BytesRef including the Lookup class and its interface...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to