[ 
https://issues.apache.org/jira/browse/LUCENE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212636#comment-13212636
 ] 

Robert Muir commented on LUCENE-3807:
-------------------------------------

I found another bug (added test and committed fix in r1291826).
This would cause an exception in solr if someone called build but the field was 
empty.

I think before proceeding with refactoring, we really need to beef up tests.
I'll help with this.
                
> Cleanup suggester API
> ---------------------
>
>                 Key: LUCENE-3807
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3807
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/other
>    Affects Versions: 3.6, 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3807.patch, LUCENE-3807.patch
>
>
> Currently the suggester api and especially TermFreqIterator don't play that 
> nice with BytesRef and other paradigms we use in lucene, further the java 
> iterator pattern isn't that useful when it gets to work with TermsEnum, 
> BytesRef etc. We should try to clean up this api step by step moving over to 
> BytesRef including the Lookup class and its interface...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to