[
https://issues.apache.org/jira/browse/LUCENE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252458#comment-13252458
]
Martijn van Groningen commented on LUCENE-3972:
-----------------------------------------------
The major difference between the committed TermAllGroupsCollector and one in
the patch is that committed TermAllGroupsCollector creates a BytesRef instance
for each unique group and puts it in a ArrayList (5M in my case). The version
in the patch reuses a single BytesRef instance. The BytesRef bytes are copied
into the BytesRefHash big bytes array via the BytesRefHash#add(...) method. I
think the many BytesRef instances makes the committed TermAllGroupsCollector
slow.
> Improve AllGroupsCollector implementations
> ------------------------------------------
>
> Key: LUCENE-3972
> URL: https://issues.apache.org/jira/browse/LUCENE-3972
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Reporter: Martijn van Groningen
> Attachments: LUCENE-3972.patch, LUCENE-3972.patch
>
>
> I think that the performance of TermAllGroupsCollectorm,
> DVAllGroupsCollector.BR and DVAllGroupsCollector.SortedBR can be improved by
> using BytesRefHash to store the groups instead of an ArrayList.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
