[
https://issues.apache.org/jira/browse/LUCENE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252463#comment-13252463
]
Dawid Weiss commented on LUCENE-3972:
-------------------------------------
Yes, sorry -- hash of course. The hash method that should redistribute keys
space into buckets (but currently doesn't).
As for BytesRefHash vs. BytesRef instances -- maybe it's the source of the
speedup, who knows. I would try the hash method though, if nothing else just
for curiosity. I would also patch it for the future in either case. Not
rehashing input keys is a flaw in my opinion (again -- backed by real life
experience from HPPC).
> Improve AllGroupsCollector implementations
> ------------------------------------------
>
> Key: LUCENE-3972
> URL: https://issues.apache.org/jira/browse/LUCENE-3972
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/grouping
> Reporter: Martijn van Groningen
> Attachments: LUCENE-3972.patch, LUCENE-3972.patch
>
>
> I think that the performance of TermAllGroupsCollectorm,
> DVAllGroupsCollector.BR and DVAllGroupsCollector.SortedBR can be improved by
> using BytesRefHash to store the groups instead of an ArrayList.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
