[ https://issues.apache.org/jira/browse/LUCENE-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458643#comment-13458643 ]
Robert Muir commented on LUCENE-4399: ------------------------------------- Hmm I'm confused by the changes to AppendingCodec: its not really a codec-wrapper its just coded that way. Actually the whole thing is very dependent on the implementation details of the current term dictionary right? thats the only place that currently seeks, where it changes the behavior. so we have a number of alternatives: * AppendingCodec extends Lucene40Codec and returns AppendingPF for every field. * remove AppendingCodec entirely (just move to test-framework), because someone could do the above themselves. > Rename AppendingCodec to Appending40Codec > ----------------------------------------- > > Key: LUCENE-4399 > URL: https://issues.apache.org/jira/browse/LUCENE-4399 > Project: Lucene - Core > Issue Type: New Feature > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Fix For: 4.0 > > Attachments: LUCENE-4399.patch > > > In order AppendingCodec to follow Lucene codecs version, I think its name > should include a version number (so that, for example, if we get to releave > Lucene 4.3 with a new Lucene43Codec, there will also be a new > Appending43Codec). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org