[ https://issues.apache.org/jira/browse/LUCENE-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458690#comment-13458690 ]
Robert Muir commented on LUCENE-4399: ------------------------------------- {quote} I like this idea better. People who want an appending codec just need to extend the last Lucene4xCodec.getPostingsFormatForField and there will be no back compat issue. Maybe we should just advertise in Lucene4xCodec javadoc that this is how to obtain an appending codec. {quote} Right my only hesitation before here was 'exposing our guts' a bit too much. For example, this scheme breaks if in lucene 4.2 you write a fancy new default stored fields format that needs to seek-on-write. But I think we shouldnt worry about this: we can just address it as it comes (and if a Codec makes sense then, lets deal with it). Its like the analysis package, if we implement something as a TokenFilter thats ok. We don't necessarily need to hide ourselves by providing an Analyzer too. If we want to make it a Tokenizer later because that makes more sense, then we just do that :) Otherwise we will have a lot of delegates and complex code for only theoretical future situations and I think we should avoid this. > Rename AppendingCodec to Appending40Codec > ----------------------------------------- > > Key: LUCENE-4399 > URL: https://issues.apache.org/jira/browse/LUCENE-4399 > Project: Lucene - Core > Issue Type: New Feature > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Fix For: 4.0 > > Attachments: LUCENE-4399.patch, LUCENE-4399.patch > > > In order AppendingCodec to follow Lucene codecs version, I think its name > should include a version number (so that, for example, if we get to releave > Lucene 4.3 with a new Lucene43Codec, there will also be a new > Appending43Codec). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org