+1 Besides the mentioned jdoc warnings the smoke tester ran fine.
On 21 December 2012 01:07, Steve Rowe <sar...@gmail.com> wrote: > +1 > > On OS X 10.8.2, the smoke tester passes for me, except for the same javadoc > errors Mike reported, under Oracle Java 1.7.0_10. (I commented out the Java7 > javadocs run after it failed for me.) > > I first had to install Java 5 using the manual instructions here (the linked > script didn't work for me): <http://www.s-seven.net/java_15_mountain_lion> > > Steve > > On Dec 19, 2012, at 6:28 PM, Michael McCandless <luc...@mikemccandless.com> > wrote: > >> I don't think these javadocs warnings require a re-spin so +1 to >> release current artifacts. >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Wed, Dec 19, 2012 at 3:46 PM, Michael McCandless >> <luc...@mikemccandless.com> wrote: >>> On Wed, Dec 19, 2012 at 2:01 PM, Robert Muir <rcm...@gmail.com> wrote: >>>> On Wed, Dec 19, 2012 at 1:48 PM, Michael McCandless >>>> <luc...@mikemccandless.com> wrote: >>>>> Hmm my smoke test run was angry about this javadocs warning: >>>>> >>>>> [javadoc] >>>>> /l/36x/tmp/unpack/apache-solr-3.6.2/lucene/contrib/facet/src/java/org/apache/lucene/facet/taxonomy/writercache/lru/NameIntCacheLRU.java:76: >>>>> warning - @return tag has no arguments. >>>>> >>>>> It hit this when running javadocs with 1.7.0_07. >>>> >>>> Thanks Mike... can you fix? I have no idea why different versions of >>>> java7 have different levels of pickiness. >>>> >>>> This is no issue for e.g. 4.x+, because we have the eclipse checker as >>>> part of our build which fails on this. But for 3.x we don't have as >>>> many tools unfortunately. >>>> >>>> I dont think we should put a lot of effort into this: but when >>>> backporting bugfixes to old branches like this please be really >>>> careful about this stuff. >>> >>> OK I committed that fix and a couple other javadocs warnings. >>> >>> Thanks for spinning 3.6.2 Robert! >>> >>> Mike McCandless >>> >>> http://blog.mikemccandless.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > -- Met vriendelijke groet, Martijn van Groningen --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
